[PATCH 2/2] Fail on incomplete ksdata when in cmdline mode

Vratislav Podzimek vpodzime at redhat.com
Thu Sep 27 08:42:05 UTC 2012


I understand that this is good for the consistency with the previous
releases, but appart from that, what is this good for? Why should we do
something like that now that our text mode is basically command-line
mode and *can* have a question? Or am I missing something?

On Wed, 2012-09-26 at 14:31 -0700, Jesse Keating wrote:
> cmdline means no prompting, so if we have spokes that are incomplete,
> raise the error.
> ---
>  pyanaconda/ui/tui/hubs/summary.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/pyanaconda/ui/tui/hubs/summary.py b/pyanaconda/ui/tui/hubs/summary.py
> index 19d2a53..f4247de 100644
> --- a/pyanaconda/ui/tui/hubs/summary.py
> +++ b/pyanaconda/ui/tui/hubs/summary.py
> @@ -54,4 +54,7 @@ class SummaryHub(TUIHub):
>          all(spoke.completed for spoke in self._keys.values()):
>              self.close()
>              return None
> +        if not flags.ksprompt:
> +            errtxt = _("Can't have a question in command line mode!")
> +            raise RuntimeError(errtxt)
>          return TUIHub.prompt(self, args)
> \ No newline at end of file

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list