[PATCH] remove rv from unmount error log

Jesse Keating jkeating at redhat.com
Fri Sep 21 17:01:27 UTC 2012


On 09/21/2012 09:57 AM, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
>
> You obviously cannot reference it when it hasn't been set.
> ---
>   src/pylorax/imgutils.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/pylorax/imgutils.py b/src/pylorax/imgutils.py
> index baac2b9..0ebb3d2 100644
> --- a/src/pylorax/imgutils.py
> +++ b/src/pylorax/imgutils.py
> @@ -133,8 +133,8 @@ def umount(mnt,  lazy=False, maxretry=3, retrysleep=1.0):
>               count += 1
>               if count == maxretry:
>                   raise
> -            logger.warn("failed to unmount %s (%d). retrying (%d/%d)...",
> -                         mnt, rv, count, maxretry)
> +            logger.warn("failed to unmount %s. retrying (%d/%d)...",
> +                         mnt, count, maxretry)
>               if logger.getEffectiveLevel() <= logging.DEBUG:
>                   fuser = execWithCapture("fuser", ["-vm", mnt])
>                   logger.debug("fuser -vm:\n%s\n", fuser)
>

ACK

-- 
Jesse Keating
Fedora -- FreedomĀ² is a feature!


More information about the anaconda-patches mailing list