[master] Patches for HW clock saving and restoring

Brian C. Lane bcl at redhat.com
Thu Sep 20 17:43:35 UTC 2012


On Wed, Sep 19, 2012 at 11:52:46AM +0200, Vratislav Podzimek wrote:
> PATCH 1/3 does only a little and rather cosmetic change and can be omitted.
> 
> PATCH 2/3 adds a thread that waits for storage initialization, then searches for
> ntfs partitions and asks bootloader if any of them are bootable. If yes, it sets
> ksdata.timezone.isUtc to False, otherwise to True. Then it restores system time
> from HW clock using the guess about UTC. The GUI part waiting for this thread to
> be finished is more or less copied from the StorageSpoke.
> 
> PATCH 3/3 adds a code for saving system time to hardware clock as a first step
> after the "point of no return", i.e. before we do any partitioning and start
> package installation. This cannot be part of the post-installation steps,
> because otherwise user could e.g. end up with partitions and data created in
> future.
> 
> Unfortunately, I cannot test the dual boot configuration with existing bootable
> ntfs partition.

I've got this vague worry about adding more threads which depend on
other threads. I'm concerned that we're going to hit a point where we
start hitting hard to reproduce problems caused by races (or other
issues) between interdependent threads. I don't have a solution and not
even a concrete description of a problem, just a worry. I'd feel better
if there was a non-threaded way to do this.

A more concrete issue: any place where we are doing things to the host
system we need to wrap them in checks for flags.imageInstall so that
someone doing a --image install doesn't end up messing up their build
system.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20120920/5bf0ce01/attachment.sig>


More information about the anaconda-patches mailing list