[PATCH 1/2] Do not use 100 % of CPU time when updating installation progress

Vratislav Podzimek vpodzime at redhat.com
Mon Sep 3 13:28:32 UTC 2012


We shouldn't use GLib.idle_add for non-oneshot functions because it
causes 100% CPU use. Let's use GLib.timeout_add_seconds instead.

Resolves: rhbz#853977

Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
---
 pyanaconda/ui/gui/hubs/progress.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pyanaconda/ui/gui/hubs/progress.py b/pyanaconda/ui/gui/hubs/progress.py
index 13d1811..1a5d7fe 100644
--- a/pyanaconda/ui/gui/hubs/progress.py
+++ b/pyanaconda/ui/gui/hubs/progress.py
@@ -146,7 +146,7 @@ class ProgressHub(Hub):
         # seconds, so we need to do the first call manually.
         self._cycle_rnotes()
 
-        self._progress_id = GLib.idle_add(self._update_progress)
+        self._progress_id = GLib.timeout_add_seconds(1, self._update_progress)
         self._rnotes_id = GLib.timeout_add_seconds(60, self._cycle_rnotes)
         threadMgr.add(AnacondaThread(name="AnaInstallThread", target=doInstall,
                                      args=(self.storage, self.payload, self.data, self.instclass)))
-- 
1.7.11.4



More information about the anaconda-patches mailing list