[PATCH 4/4] only clear errors if re-running the check (#868707)
Vratislav Podzimek
vpodzime at redhat.com
Fri Oct 26 08:58:18 UTC 2012
This and the patches 2/4 and 3/4 looks good to me except that I don't
see any relation between this patch and rhbz#868707. Wrong number?
On Thu, 2012-10-25 at 13:04 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
>
> This was clearing custom partition errors as well. We only want to clear
> the errors before re-running the StorageCheck thread.
>
> Also add a check to make sure the StorageCheck thread is done before we
> being complete. If it isn't done then the check for errors could be
> invalid.
> ---
> pyanaconda/ui/gui/spokes/storage.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/pyanaconda/ui/gui/spokes/storage.py b/pyanaconda/ui/gui/spokes/storage.py
> index 7aab762..2557132 100644
> --- a/pyanaconda/ui/gui/spokes/storage.py
> +++ b/pyanaconda/ui/gui/spokes/storage.py
> @@ -413,9 +413,9 @@ class StorageSpoke(NormalSpoke, StorageChecker):
>
> self.disks = getDisks(self.storage.devicetree)
> else:
> - self.errors = []
> if self.autopart:
> # this was already run as part of doAutoPartition. dumb.
> + self.errors = []
> self.run()
> finally:
> self._ready = True
> @@ -424,6 +424,7 @@ class StorageSpoke(NormalSpoke, StorageChecker):
> @property
> def completed(self):
> return (threadMgr.get("AnaExecuteStorageThread") is None and
> + threadMgr.get("AnaCheckStorageThread") is None and
> self.storage.rootDevice is not None and
> not self.errors)
>
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list