[PATCH] checkisomd5 hack

Brian C. Lane bcl at redhat.com
Wed Oct 24 00:55:18 UTC 2012


From: "Brian C. Lane" <bcl at redhat.com>

A. This is untested, I'm looking for comments before I go to the trouble of
   building an iso with it.

B. I don't really like any of these options, but this is the best one I can
   think of right now.

rd.live.check isn't doing anything for the non-livecd install media. The
problem is that dmsquash-live-root needs the device in order for its call to
checkisomd5 to work and anaconda-dracut always passes the path to the image.
The options I see are:

1. move the checkisomd5 into a dracut-lib function. The problem with this is
   that adds dependencies (checkisomd5) to every use of dracut.

2. pass the device to anaconda_live_root_dir, pass that as an option to
   dmsquash-live-root and have it check for an optional device argument to run
   checkisomd5 on. I like this option the least.

3. copy the checkisomd5 code from dmsquash-live-root to anaconda-lib. This
   introduces a dep on dracut-lib inside our lib because of the getarg function.
   I'm not sure if that's a problem or not. If not, this would be my 1st choice.

4. copy it into anaconda-diskroot which is the only place it will be used
   anyway.

#4 is in the following patch. I like #3 as long as adding dracut-lib to every
call of anaconda-lib won't cause problems.


Brian C. Lane (1):
  run checkisomd5 from anaconda-diskroot (#848764)

 dracut/anaconda-diskroot | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

-- 
1.7.11.7



More information about the anaconda-patches mailing list