[pykickstart] [PATCH] Add support for layout switching options

Vratislav Podzimek vpodzime at redhat.com
Tue Oct 23 08:02:01 UTC 2012


On Mon, 2012-10-22 at 17:03 -0400, Chris Lumens wrote:
> > @@ -92,18 +93,23 @@ class F18_Keyboard(FC3_Keyboard):
> >                  layouts_str += ",'%s'" % layout
> >              retval += " --xlayouts=%s" % layouts_str
> >  
> > +        if self.switch_opts:
> > +            retval += " --switch=%s" % ", ".join(switch_opts)
> > +
> 
> You are joining on ", ", which means your argument string there is going
> to have spaces in it.  That's not what you want.  Also, you may wish to
> consider surrounding the whole thing in quotes since it seems like the
> option can have some unusual characters in it.
Good catch, thanks. I'll use the same code as in the --xlayouts case.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list