[PATCH 2/5] Everywhere we make a MountpointSelector, give it a _root attr (#868702).

Brian C. Lane bcl at redhat.com
Tue Oct 23 00:23:09 UTC 2012


On Mon, Oct 22, 2012 at 04:55:18PM -0400, Chris Lumens wrote:
> ---
>  pyanaconda/ui/gui/spokes/custom.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
> index f64d416..1405986 100644
> --- a/pyanaconda/ui/gui/spokes/custom.py
> +++ b/pyanaconda/ui/gui/spokes/custom.py
> @@ -842,6 +842,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
>              selector = page.addDevice(name, Size(spec="%f MB" % _device.size),
>                                        mountpoint, self.on_selector_clicked)
>              selector._device = _device
> +            selector._root = None

Shouldn't this be done in addDevice? It's safer to have whatever is
creating the selector setup defaults than it is to have every use of it
remember.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121022/fc82f6bb/attachment.sig>


More information about the anaconda-patches mailing list