[PATCH master] Fix configuration of protected wireless connections (#855526).
Radek Vykydal
rvykydal at redhat.com
Fri Oct 12 12:10:02 UTC 2012
On 10/11/2012 07:16 PM, Brian C. Lane wrote:
> On Thu, Oct 11, 2012 at 10:14:54AM +0200, Radek Vykydal wrote:
>> F18 Beta blocker.
>>
>> With this fix, wireless secrets can be set in nm-c-e with [Configure]
>> button.
>>
>> I am planning to use secret agent for wireless secrets (either nm-applet or our own). Currently NM requires running session for secret agent which is very hard to achieve in Anaconda. Dan Williams is working
>> on support for private dbus socket where session will not be required
>> for the agent.
> Really long lines in the commit message
>
Yes, it is not actually part of commit message,
I malformated somehow this additional comment.
>> + if active_ap:
>> + combobox = self.builder.get_object("combobox_wireless_network_name")
>> + store = combobox.get_model()
>> + i = store.get_iter_first()
>> + while i:
>> + if store[i][1] == active_ap.get_ssid():
>> + combobox.set_active_iter(i)
>> + self.selected_ssid = active_ap.get_ssid()
>> + break
>> + i = store.iter_next(i)
> I think you can just iterate this normally:
> for i in combobox.get_model():
>
>
I knew there must be some pythonic way other
than this ugly while loop, sending new version of the patch.
More information about the anaconda-patches
mailing list