[PATCH 4/4] Not every device has a resizable attribute (#862972).

David Lehman dlehman at redhat.com
Mon Oct 8 16:25:03 UTC 2012


On Mon, 2012-10-08 at 11:57 -0400, Chris Lumens wrote:
> > dev is None, which means the getDeviceByPath call didn't find a matching
> > device. You probably want to check for that right after that call, log
> > it, and continue.
> 
> Oh, that was dumb of me.
> 
> Well anyway, doesn't dev being None seem like a larger problem?

Two things I noticed upon further examination:

1) If StorageSpoke._doExecute's call to doKickstartStorage fails, we
   reset storage. What we do not do is reinitialize the spoke in that
   event so that all the disk instances are in the new storage instance.
   I think this is what's happening here: the disk list being passed
   around the UI is obsolete.
2) The loop that iterates over disks in the resize dialog's populate
   method does not take into account the possibility that a disk is
   not partitioned.

Dave



More information about the anaconda-patches mailing list