[PATCH] update to use firewalld (#815540)

Brian C. Lane bcl at redhat.com
Thu Oct 4 15:51:55 UTC 2012


On Thu, Oct 04, 2012 at 08:52:27AM +0200, Vratislav Podzimek wrote:
> On Wed, 2012-10-03 at 12:40 -0700, Brian C. Lane wrote:
> > +class Firewall(commands.firewall.F14_Firewall):
> > +    def execute(self, storage, ksdata, instClass):
> > +        args = []
> > +        # enabled is None is neither --enable or --disable is passed
> 		            ^^ typo?
> 
> Otherwise this looks good to me.

Whoops, should be 'if'. Thanks.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121004/89178961/attachment.sig>


More information about the anaconda-patches mailing list