[PATCH 1/8] Add a resize dialog.

Chris Lumens clumens at redhat.com
Wed Oct 3 14:44:01 UTC 2012


> I don't follow the logic behind initialize and refresh methods of this
> dialog. Things like getting objects from the glade file are usually done
> in the initialize methods of the GUIObjects and refresh methods only
> refresh GUI. Maybe renaming 'initialize' to something like
> 'initialize_disk_store' and moving self.builder.get_object() invocations
> together with the "# Shouldn't have to do this outside of glade" part to
> separate method (initialize or __init__) would help.

Yeah you're right, I did kind of make a mess of this kind of stuff.
I'll clean it up.

On stuff like these standalone dialogs, initialize/refresh aren't even
that important since it's up to the caller to decide what to do.  With
Spokes, the Hub code enforces those things needing to exist because it
does the calling.  It's much looser with dialogs, so I allowed myself to
just do whatever.  Whoops.

- Chris


More information about the anaconda-patches mailing list