[PATCH] - resize support

Vratislav Podzimek vpodzime at redhat.com
Wed Oct 3 08:00:00 UTC 2012


Apart from the one comment, this looks good to me. I didn't apply the
patch to review the look of the dialog (screenshot would be helpful),
but some polishing may follow if needed.

On Tue, 2012-10-02 at 15:02 -0400, Chris Lumens wrote:
> The following patch set adds the partition resize/delete dialog needed to move
> us away from defaulting to CLEARPART_TYPE_ALL.  It's not exactly perfect, but
> it should be pretty good.  Things that could use work:
> 
> * Popping up the dialog and taking it away doesn't look very good.  This is
> largely an effect of displaying dialogs from dialogs, I think.
> 
> * Action->Shrink needs to be hidden for devices that do not support resizing.
> I think this is pretty hard to do, so right now Shrink will just do the same
> thing as Delete for those devices.
> 
> * I might need more hard drive identifying information?
> 
> * Error reporting can be vague, but that's a problem reaching down into storage
> and not something UI-specific.
> 
> * Resizing is a best-effort action, and it's highly prone to error.  For
> instance if you have an existing format of /boot, swap, and / and you tell it to
> delete swap and resize / you still may not end up with enough free space to do
> an install.  This is due to still having data in the smaller / partition right
> in the middle of two big sections of free space.  You've got enough free space
> but it's not contiguous.
> 
> I'm seeing this consistently with my tiny 8 GB VM disk.  I'm not sure it's a big
> enough deal though.
> 
> Anyway as always, it's best to get stuff out in front of people so we can all
> work on the polish.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list