[PATCH 1/8] Add a resize dialog.

Vratislav Podzimek vpodzime at redhat.com
Wed Oct 3 07:53:12 UTC 2012


On Tue, 2012-10-02 at 15:02 -0400, Chris Lumens wrote:
> +    def refresh(self, disks):
> +        super(ResizeDialog, self).refresh()
> +
> +        self._actionStore = self.builder.get_object("actionStore")
> +        self._diskStore = self.builder.get_object("diskStore")
> +
> +        self._view = self.builder.get_object("diskView")
> +        self._diskStore = self.builder.get_object("diskStore")
> +        self._reclaimable_label = self.builder.get_object("reclaimableSpaceLabel")
> +        self._selected_label = self.builder.get_object("selectedSpaceLabel")
> +
> +        # clear out the store and repopulate it from the devicetree
> +        self._diskStore.clear()
> +        self.initialize(disks)
I don't follow the logic behind initialize and refresh methods of this
dialog. Things like getting objects from the glade file are usually done
in the initialize methods of the GUIObjects and refresh methods only
refresh GUI. Maybe renaming 'initialize' to something like
'initialize_disk_store' and moving self.builder.get_object() invocations
together with the "# Shouldn't have to do this outside of glade" part to
separate method (initialize or __init__) would help.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list