cannot find the hard drive for bios disk 80

B_B_Singh at DELL.com B_B_Singh at DELL.com
Wed Oct 3 05:39:26 UTC 2012


Hi,

Thanks for the comments,
Below comments are updated , plz let me results of your testing.
Find the attachment.

Regards
Balaji Singh

-----Original Message-----
From: anaconda-patches-bounces at lists.fedorahosted.org [mailto:anaconda-patches-bounces at lists.fedorahosted.org] On Behalf Of Vratislav Podzimek
Sent: Monday, October 01, 2012 9:51 PM
To: anaconda-patches at lists.fedorahosted.org
Subject: Re: cannot find the hard drive for bios disk 80

On Mon, 2012-10-01 at 15:26 +0530, B_B_Singh at DELL.com wrote:
> Hi,
> 
> I have made the corrections as per the below comments,  the patch shows no indentation in linux. 
I've used Emacs to open the patch file. Opening in Vim shows me, that you (or your editor) are mixing tabs and spaces. Also there was (looks like it is fixed in the version below) some trailing whitespace. Please see the last two comments below. Once this gets fixed, I'll try to build anaconda with the patch applied and in case of no problems, I will push it.

> Plz find the patch in the attachment.
> 
> Regards
> Balaji Singh
> ----------------------------------------------------------------------
> ------------------------------------------------------------
> diff -rau anaconda-13.21.176_old/isys/eddsupport.c anaconda-13.21.176/isys/eddsupport.c
> --- anaconda-13.21.176_old/isys/eddsupport.c    2012-06-12 15:40:09.000000000 -0400
> +++ anaconda-13.21.176/isys/eddsupport.c        2012-10-01 09:46:40.399867053 -0400
> @@ -47,6 +47,7 @@
> 
>  #define HASH_TABLE_SIZE 17
> 
> +uint8_t bios_disk_err = 0;
> 
>  struct diskMapEntry{
>      uint32_t key;
> @@ -323,7 +324,7 @@
>      struct diskMapEntry * disk;
>      int ret;
> 
> -    if (diskHashInit == 0) {
> +    if (diskHashInit == 0 || bios_disk_err == 1) {
>          probeBiosDisks();
>          diskHashInit = 1;
>      }
> @@ -333,7 +334,14 @@
> 
>      ret = sscanf(biosStr,"%x",&biosNum);
>      disk = lookupHashItem(mbrSigToName, biosNum);
> -    if (disk) return disk->diskname;
> 
> +    if (disk) {
> +       bios_disk_err = 0;
> +       return disk->diskname;
> +    }
> +    else {
> +       bios_disk_err = 1;
> +    }
> +
>      return NULL;
>  }
> diff -rau anaconda-13.21.176_old/loader/hdinstall.c anaconda-13.21.176/loader/hdinstall.c
> --- anaconda-13.21.176_old/loader/hdinstall.c   2012-06-12 15:40:09.000000000 -0400
> +++ anaconda-13.21.176/loader/hdinstall.c       2012-10-01 09:57:35.189892680 -0400
> @@ -54,6 +54,7 @@
>  /* boot flags */
> extern uint64_t flags;
> 
> +extern uint8_t bios_disk_err;
>  /* given a partition device and directory, tries to mount hd install 
> image */  static char * setupIsoImages(char * device, char * dirName, char * location) {
>      int rc = 0;
> @@ -448,7 +449,7 @@
> 
> 
>  int kickstartFromBD(char *kssrc) {
> -    int rc;
> +    int rc, iter=0;
>      char *p, *np = NULL, *r = NULL, *tmpstr, *ksdev, *kspath, 
> *biosksdev;
> 
>      logMessage(INFO, "getting kickstart file from biosdrive"); @@ 
> -478,6 +479,12 @@
> 
>      *r = '\0';
>      biosksdev = getBiosDisk((p + 1));
> +    /*Probing the bios disks for 5 times or waiting for 30 seconds */
> +    for (iter = 0; bios_disk_err && iter< 5; ++iter){
				           ^^ missing space
> +       logMessage(INFO, "Probing the bios storage devices, Retry 
> + count is %d out of 5, Sleeping for %d seconds", (iter+1),(1 << 
> + iter));
Please, split this line into two.

Thanks,

--
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic

_______________________________________________
anaconda-patches mailing list
anaconda-patches at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slow_bios_disk_err3.patch
Type: application/octet-stream
Size: 2160 bytes
Desc: slow_bios_disk_err3.patch
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121003/b11f98ed/attachment.obj>


More information about the anaconda-patches mailing list