[master] [PATCH] Do not use constant value in SoftwareSpoke's completed property

Vratislav Podzimek vpodzime at redhat.com
Tue Oct 2 17:50:22 UTC 2012


packagesSeen is a value, that should not be changed in spokes. Using
it as a condition for the completed property results in no way of
completing software spoke in kickstart installation without %packages
section. Without %packages section in kickstart, SoftwareSpoke's
completed method should use the same code as in manual installations.

Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
---
 pyanaconda/ui/gui/spokes/software.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
index fb172cb..10b4d48 100644
--- a/pyanaconda/ui/gui/spokes/software.py
+++ b/pyanaconda/ui/gui/spokes/software.py
@@ -105,8 +105,8 @@ class SoftwareSelectionSpoke(NormalSpoke):
                          not self._errorMsgs and \
                          self._tx_id == self.payload.txID
 
-        if flags.automatedInstall:
-            return packagesSeen and processingDone
+        if flags.automatedInstall and packagesSeen:
+            return processingDone
         else:
             return self._get_selected_environment() is not None and processingDone
 
-- 
1.7.11.4



More information about the anaconda-patches mailing list