cannot find the hard drive for bios disk 80

Vratislav Podzimek vpodzime at redhat.com
Mon Oct 1 07:36:50 UTC 2012


> +    if (disk) {
> +    bios_disk_err = 0;
> +    return disk->diskname;
> +    }     
> +    else {
> +    bios_disk_err = 1;
> +    }      
Please stick with the indentation style of the file (and also the rest
of your changes).

> +    /*Probing the bios disks for 5 times or waiting for 30 seconds */
> +    for(iter=0;bios_disk_err && iter< 5;++iter){
                                      ^^ whitespace

> +    logMessage(INFO, "Probing the bios storage devices, Retry count
> is %d out of 5, Sleeping for %d seconds", (iter+1),(1 << iter));
> +        sleep(1 << iter);
         ^^ whitespace

> +    	biosksdev = getBiosDisk((p + 1));
No need for the double parentheses.

Otherwise it looks good to me, just please note that using 'git
send-email' [1] makes it easier for us to review the patch(es).

[1] http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list