Fix iutil.execWithCapture() with fatal and non-zero exit

Stef Walter stefw at redhat.com
Mon Nov 19 12:03:43 UTC 2012


When iutil.execWithCapture() is called with fatal=True and the process
exits with a non-zero exit code a TypeError:

TypeError: cannot concatenate 'str' and 'NoneType' objects

on this line:

        log.error ("Error running " + command + ": " + e.strerror)

The attached patches fix the problem and add a test for the issue.

When I ran all the tests (using 'make unittest' or 'sudo make unittest')
I got thousands of failures, so I just ran the one I added using:

cd tests/pyanaconda_test; PYTHONPATH=../../pyanaconda/:../:. python -m
unittest iutil_test.IutilTest

Cheers,

Stef


More information about the anaconda-patches mailing list