[PATCH] only call bootloader.check() if bootloader is setup (#875278)

David Lehman dlehman at redhat.com
Fri Nov 16 22:32:04 UTC 2012


ACK

On Fri, 2012-11-16 at 14:19 -0800, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
> 
> ---
>  pyanaconda/storage/__init__.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py
> index ee156a1..185fabb 100644
> --- a/pyanaconda/storage/__init__.py
> +++ b/pyanaconda/storage/__init__.py
> @@ -1528,6 +1528,8 @@ class Storage(object):
>                  self.bootloader.is_valid_stage2_device(stage2)
>                  errors.extend(self.bootloader.errors)
>                  warnings.extend(self.bootloader.warnings)
> +                if not self.bootloader.check():
> +                    errors.extend(self.bootloader.errors)
>  
>              #
>              # check that GPT boot disk on BIOS system has a BIOS boot partition
> @@ -1548,9 +1550,6 @@ class Storage(object):
>                                      "please create a 1MB 'BIOS Boot' type "
>                                      "partition.") % productName)
>  
> -            if not self.bootloader.check():
> -                errors.extend(self.bootloader.errors)
> -
>          if not swaps:
>              from pyanaconda.storage.size import Size
>  




More information about the anaconda-patches mailing list