[rhel6.4] Reserve 50% of VG for interactive installs (#875918)

Vratislav Podzimek vpodzime at redhat.com
Thu Nov 15 20:29:24 UTC 2012


On Thu, 2012-11-15 at 11:55 -0800, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
> 
> ---
>  kickstart.py       | 3 ++-
>  storage/devices.py | 4 +++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/kickstart.py b/kickstart.py
> index ec9ca90..493a7c6 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -1160,7 +1160,8 @@ class VolGroupData(commands.volgroup.F16_VolGroupData):
>              storage.createDevice(request)
>              if self.reserved_space:
>                  request.reserved_space = self.reserved_space
> -            elif self.reserved_percent:
> +                request.reserved_percent = 0
> +            else:
>                  request.reserved_percent = self.reserved_percent
>  
>  class XConfig(commands.xconfig.F10_XConfig):
> diff --git a/storage/devices.py b/storage/devices.py
> index fdc4649..0ff016c 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -1871,7 +1871,7 @@ class LVMVolumeGroupDevice(DMDevice):
>          self.lv_sizes = []
>          self.lv_attr = []
>          self.hasDuplicate = False
> -        self.reserved_percent = 0
> +        self.reserved_percent = 50
>          self.reserved_space = 0
>  
>          # circular references, here I come
> @@ -1942,6 +1942,8 @@ class LVMVolumeGroupDevice(DMDevice):
>          elif self.reserved_percent:
>              args.append("--reserved-percent=%d" % self.reserved_percent)
>  
> +        if self.reserved_percent or self.reserved_space:
> +            f.write("# %s has space reserved for future upgrades\n" % (self.name,))
>          f.write("#volgroup %s %s %s" % (self.name, " ".join(args), " ".join(pvs)))
>          if s:
>              f.write(" %s" % s)
Code changes look good to me, in contrast to the whole idea behind them.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list