[PATCH] rm transifex-client buildreq
David Cantrell
dcantrell at redhat.com
Wed Nov 14 18:45:46 UTC 2012
On Wed, Nov 14, 2012 at 06:43:57PM +0100, Vratislav Podzimek wrote:
> On Wed, 2012-11-14 at 10:43 -0500, Samantha N. Bueno wrote:
> > transifex-client shouldn't be listed as a BuildReq; only check for it
> > and install as needed if the target requiring it is called by make
> > ---
> > Makefile.am | 9 +++++++++
> > anaconda.spec.in | 1 -
> > 2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index 4f76895..cee2b4a 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -45,6 +45,7 @@ sed_verbose_0 = @echo " SED "$@;
> >
> > TX_PULL_ARGS = -a --disable-overwrite
> > TX_PUSH_ARGS = -s
> > +tx_installed=`rpm -qa transifex-client`
> >
> > $(PACKAGE_NAME).spec: $(PACKAGE_NAME).spec.in
> > $(sed_verbose)sed -e 's/#VERSION#/$(PACKAGE_VERSION)/' < $< > $@
> > @@ -56,6 +57,10 @@ tag:
> > po-pull:
> > rm -f po/en at boldquot.gmo po/en at boldquot.po
> > rm -f po/en at quot.gmo po/en at quot.po
> > +
> > + if [ -z "$tx_installed" ]; then \
> > + yum install transifex-client
> > + fi
> > tx pull $(TX_PULL_ARGS)
> >
> > scratch: po-pull
> > @@ -81,6 +86,10 @@ bumpver: po-pull
> > fi ; \
> > scripts/makebumpver $${opts} || exit 1 ; \
> > $(MAKE) -C po $(PACKAGE_NAME).pot-update ; \
> > +
> > + if [ -z "$tx_installed" ]; then \
> > + yum install transifex-client
> > + fi
> > tx push $(TX_PUSH_ARGS)
> >
> > install-buildrequires:
> > diff --git a/anaconda.spec.in b/anaconda.spec.in
> > index 61dd7ef..7b20a2a 100644
> > --- a/anaconda.spec.in
> > +++ b/anaconda.spec.in
> > @@ -80,7 +80,6 @@ BuildRequires: python-nose
> > BuildRequires: rpm-devel
> > BuildRequires: rpm-python >= %{rpmpythonver}
> > BuildRequires: slang-devel >= %{slangver}
> > -BuildRequires: transifex-client
> > BuildRequires: xmlto
> > BuildRequires: yum >= %{yumver}
> > BuildRequires: zlib-devel
> Is there any bugreport for this? It looks good to me, but maybe we
> should ask user if he/she really wants us to install transifex-client
> and tell user to configure it before building anaconda. Maybe also point
> them to our docs/transifex.txt file?
We don't have a bug report for this right now. The concern is preventing
the import of things not explicitly needed for building the SRPM in to brew.
--
David Cantrell <dcantrell at redhat.com>
Manager, Installer Engineering Team
Red Hat, Inc. | Westford, MA | EST5EDT
More information about the anaconda-patches
mailing list