[newui] patch dump

David Lehman dlehman at redhat.com
Fri Jun 29 18:25:51 UTC 2012


On Fri, 2012-06-29 at 11:30 -0400, Chris Lumens wrote:
> > All storage related. Lots to do with uninitialized disk handling.
> 
> Testing with a single uninitialized disk:
> 
> * Choose the single disk, autopart, review or don't:
> 
>    storage/spokes.py:277 - IndexError: list index out of range

I'd forgotten I was enabling zerombr here, but not in these patches.

I think uninitialized disk handling is going to require one of the
following approaches:

 1) Initialize any uninitialized disk that gets selected
 2) Don't let users select uninitialized disks until we have
    ui to allow users to initialize them

> 
> * Choose the single disk, click on the link to the disk cart:
> 
>    lib/cart.py:51 - AttributeError: 'DeviceFormat' object has no
>    attribute 'free'

This is because the shopping cart isn't using Storage.getFreeSpace. This
is not caused by these patches. I have a patch in my tree to convert it
to use getFreeSpace, which will fix this error.

> 
> Testing with a single initialized disk appears okay.
> 
> I'm still seeing the previously mentioned behavior where the accordion
> collapses when you delete a filesystem, but that's probably not caused
> by these patches.

I don't remember ever seeing any behavior other than what you describe
above.

> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list