[rhel7/newui/master] Let kickstart users log to device nodes (#835563)

Brian C. Lane bcl at redhat.com
Tue Jun 26 21:39:44 UTC 2012


On Tue, Jun 26, 2012 at 04:01:08PM -0400, Will Woods wrote:
> On Tue, 2012-06-26 at 11:48 -0700, Brian C. Lane wrote:
> > From: "Brian C. Lane" <bcl at redhat.com>
> > 
> > If a kickstart pre/post fails we read the logfile and add it to the
> > anaconda log. This doesn't work well for device nodes like /dev/console
> > so skip reading if it is a device node.
> 
> Not super-happy with the path check; what if we're looking
> at /run/sysroot/dev or something?
> 
> Why not just check to see if it's a regular file or not? e.g.:
>     if not os.path.isfile(self.logfile):
> 
> os.path.isfile() should return true for regular files and symbolic links
> to regular files; everything else will be false. I think that's the
> behavior we'd want?

Good idea!

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://fedorahosted.org/pipermail/anaconda-patches/attachments/20120626/37998e50/attachment.sig>


More information about the anaconda-patches mailing list