[PATCH 2/6] Add some nicer wording to the column heads in the software selection UI.

Bill Nottingham notting at redhat.com
Wed Jul 25 19:15:43 UTC 2012


Chris Lumens (clumens at redhat.com) said: 
> > diff --git a/pyanaconda/ui/gui/spokes/software.ui b/pyanaconda/ui/gui/spokes/software.ui
> > index 20bbaa3..cd8ba9f 100644
> > --- a/pyanaconda/ui/gui/spokes/software.ui
> > +++ b/pyanaconda/ui/gui/spokes/software.ui
> > @@ -70,7 +70,7 @@
> >                              <property name="visible">True</property>
> >                              <property name="can_focus">False</property>
> >                              <property name="halign">start</property>
> > -                            <property name="label" translatable="yes">DESKTOP</property>
> > +                            <property name="label" translatable="yes">Choose your installation type</property>
> >                              <attributes>
> >                                <attribute name="weight" value="bold"/>
> >                              </attributes>
> 
> I don't really like "installation type" here.  Do you see the left hand
> side containing any non-desktops besides minimal?  Because the wording
> you've chosen here makes it look like that's what you're setting up for,
> whereas our design discussions were pretty well centered around the
> concept of choosing a desktop environment.

Yes, especially for a server class installation. Basically, by hardcoding
'desktop' here we're making implied assumptions about the product anaconda
is installing - I want to avoid any of these in anaconda itself.

Bill


More information about the anaconda-patches mailing list