[PATCH] Keep format _mountType in sync with _type (#828650)

David Lehman dlehman at redhat.com
Wed Jul 4 02:08:37 UTC 2012


On Mon, 2012-07-02 at 23:43 -0700, Jesse Keating wrote:
> Device formats have both a type and mountType property.  The mountType
> property has a fallback of reading the _type attribute, if _mountType
> isn't set.  But when we're migrating filesystems, the _mountType will
> have already been set, so just modifying _type won't effect any code
> looking at mountType.  This can lead to the wrong data being written out
> to say /etc/fstab.

Ack.

> ---
>  pyanaconda/storage/formats/fs.py |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pyanaconda/storage/formats/fs.py b/pyanaconda/storage/formats/fs.py
> index cc7b4ca..ad8d356 100644
> --- a/pyanaconda/storage/formats/fs.py
> +++ b/pyanaconda/storage/formats/fs.py
> @@ -411,6 +411,7 @@ class FS(DeviceFormat):
>          # the other option is to actually replace this instance with an
>          # instance of the new filesystem type.
>          self._type = self.migrationTarget
> +        self._mountType = self.migrationTarget
>  
>      @property
>      def resizeArgs(self):




More information about the anaconda-patches mailing list