[PATCH 16/16] Split ksdata execute and setup methods for addons

Martin Sivak msivak at redhat.com
Fri Dec 14 10:32:39 UTC 2012


It could take some time.. NTP setup, IPA/AD/Samba domain registration, ... so yes, I would prefer keeping the message.

----- Original Message -----
> > diff --git a/pyanaconda/install.py b/pyanaconda/install.py
> > index 4e552ea..af214ba 100644
> > --- a/pyanaconda/install.py
> > +++ b/pyanaconda/install.py
> > @@ -109,9 +109,12 @@ def doInstall(storage, payload, ksdata,
> > instClass):
> >      steps = len(storage.devicetree.findActions(type="create",
> >      object="format")) + \
> >              len(storage.devicetree.findActions(type="resize",
> >              object="format")) + \
> >              len(storage.devicetree.findActions(type="migrate",
> >              object="format"))
> > -    steps += 4  # packages setup, packages, bootloader, post
> > install
> > +    steps += 5  # pre setup phase, packages setup, packages,
> > bootloader, post install
> >      progress.send_init(steps)
> >  
> > +    with progress_report(_("Setting up the install environment")):
> > +        ksdata.addon.setup(storage, ksdata, instClass)
> > +
> >      # Do partitioning.
> >      payload.preStorage()
> >      turnOnFilesystems(storage)
> 
> Do you expect this step to take a significant amount of time?  If
> not,
> I'd prefer to just skip the progress reporting.  If you do expect it
> to
> take enough time to report, I'd prefer the text:
> 
>     "Setting up the installation environment"
> 
> The thing is, we have an awful lot of strings about setting up and
> preparing to do things.  If we can skip adding more, I'm all for it.
> I'd prefer we just get to doing the installation than preparing.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list