[PATCH 01/16] Split completed and mandatory attributes

Martin Sivak msivak at redhat.com
Fri Dec 14 10:15:02 UTC 2012


There is no way to decide if it was filled or uses default arguments. And firstboot needs to know that to decide if it should show the spoke again or not.

----- Original Message -----
> > diff --git a/pyanaconda/ui/common.py b/pyanaconda/ui/common.py
> > index bcac8b4..3452a04 100644
> > --- a/pyanaconda/ui/common.py
> > +++ b/pyanaconda/ui/common.py
> > @@ -171,13 +171,23 @@ class Spoke(UIObject):
> >  
> >      @property
> >      def completed(self):
> > -        """Has this spoke been visited and completed?  If not, a
> > special warning
> > -           icon will be shown on the Hub beside the spoke, and a
> > highlighted
> > -           message will be shown at the bottom of the Hub.
> >  Installation will not
> > -           be allowed to proceed until all spokes are complete.
> > +        """Has this spoke been visited and completed?  If not and
> > the spoke is
> > +           mandatory, a special warning icon will be shown on the
> > Hub beside the
> > +           spoke, and a highlighted message will be shown at the
> > bottom of the
> > +           Hub.  Installation will not be allowed to proceed until
> > all mandatory
> > +           spokes are complete.
> >          """
> >          return False
> >  
> > +    @property
> > +    def mandatory(self):
> > +        """Mark this spoke as mandatory. Installation will not be
> > allowed
> > +           to proceed until all mandatory spokes are complete.
> > +
> > +           Spokes are mandatory unless marked as not being so.
> > +        """
> > +        return True
> > +
> 
> Currently, we kind of fake having a mandatory setting by marking a
> spoke
> as incomplete if whatever ksdata it needs is not filled in, then
> attempting to fill in everything when the spoke is created.  Could
> you
> give me an example of what new thing requires a new setting?'
> 
> Also, since you set mandatory = True in the base class here, you
> should
> be able to get rid of the property from most of the other spoke
> classes
> changed in this patch.
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list