[PATCH 16/16] Split ksdata execute and setup methods for addons
Martin Sivak
msivak at redhat.com
Thu Dec 13 17:04:23 UTC 2012
> > for k, v in self.__dict__.iteritems():
> > - v.execute(storage, ksdata, instClass)
> > -
> > + if hasattr(v, "execute"):
> > + v.execute(storage, ksdata, instClass, users)
> Isn't execute method mandatory? I guess you are trying to prevent
> tracebacks, but we should probably check that much sooner, or provide
>
> def execute(...):
> pass
>
> in the generic Addon class.
It is mandatory and I provide the empty method too, this is just defensive programming :)
> > - handler = AnacondaKSHandler(constants.addon_paths)
> > + handler = AnacondaKSHandler(addon_paths)
> Will this work? Are you importing addon_paths from the constants
> module
> somewhere?
there is "from constants import *" in that file at or around line 41
More information about the anaconda-patches
mailing list