[master] Checkbutton for language-default layout only

Vratislav Podzimek vpodzime at redhat.com
Tue Dec 11 09:12:01 UTC 2012


On Mon, 2012-12-10 at 15:45 -0500, Chris Lumens wrote:
> > This patch adds checkbutton as was suggested in the bugzilla discussion.
> > The result can be seen at [1]. I know the text is quite small, but I didn't
> > find ay way how to set attributes of the checkbutton's label. We could
> > either leave it as it is or use checkbutton with no label, add new label
> > next to it and wire click events on the label to checkbutton toggling.
> > 
> > [1] http://vpodzime.fedorapeople.org/welcome_spoke_new_checkbutton.png
> 
> After reading the bug, I guess I'm okay with this (especially given
> mizmo's input), though I am concerned about the precedent of solving
> things with checkboxes.  We need to continue to fight this so that we
> only do it where we absolutely need to.
Yeah, I agree with that, but for now I don't think we have a better
solution. As we have already discussed some basic keyboard configuration
UI elements should probably appear on the welcome spoke so this should
be a temporary solution only for F18.

> 
> I'm not really concerned about the size of the text.  If you really need
> to, you can do it in python by reaching down into the button:
> 
>     button.get_children()[0]
> 
> That should be the label, and then you can call set_attributes() or
> whatever to deal with it.
Thanks for the tip. Since that checkbox is not anything of high
importance I believe we can avoid adding such piece of code and leave
the text size as it is. Thus I'm pushing the patch as it is.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list