[PATCH 1/2] Hide VG-related widgets when displaying a non-LV mountpoint first (#885131).

Chris Lumens clumens at redhat.com
Fri Dec 7 19:17:29 UTC 2012


Remember that after the refresh method, a show_all() will be called.  Thus it's
not good enough to call hide.  You must also call set_no_show_all(True) on the
widgets you want to be hidden.
---
 pyanaconda/ui/gui/spokes/custom.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index d819dc9..8a326c8 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -2321,17 +2321,17 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
             if default_vg is None:
                 vg_combo.set_active(len(vg_combo.get_model()) - 1)
 
-            vg_combo.show()
-            vg_button.show()
-            vg_label.show()
+            for widget in [vg_label, vg_combo, vg_button]:
+                widget.set_no_show_all(False)
+                widget.show()
 
             # make the combo and button insensitive for existing LVs
             can_change_vg = (device is not None and not device.exists)
             vg_combo.set_sensitive(can_change_vg)
         else:
-            vg_label.hide()
-            vg_combo.hide()
-            vg_button.hide()
+            for widget in [vg_label, vg_combo, vg_button]:
+                widget.set_no_show_all(True)
+                widget.hide()
 
     def on_device_type_changed(self, combo):
         if not self._initialized:
-- 
1.7.11.2



More information about the anaconda-patches mailing list