[pykickstart] [PATCH] Beware of possibly unicode strings (#876293)

Vratislav Podzimek vpodzime at redhat.com
Wed Dec 5 11:46:49 UTC 2012


On Tue, 2012-12-04 at 10:47 -0500, Chris Lumens wrote:
> > __str__ method should return byte string, not unicode string. But
> > as we don't have a check in every KS_OBJECT.__str__ method, let's at
> > least add try-except block to prevent UnicodeDecodeError tracebacks.
> 
> I think this is okay, but this is the kind of change I would very much
> like to see some test cases for.
Good idea, I'm sending another patch for that. I guess these two could
be squashed before pushing.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list