[PATCH] anaconda realm command

Stef Walter stefw at redhat.com
Tue Dec 4 10:51:48 UTC 2012


Thanks for the review. Made the changes noted to the attached patches.

On 12/03/2012 06:42 PM, Vratislav Podzimek wrote:
> Are you expecting some empty lines at the begining of the output?

Nope. Your code is more readable so I've put it in the patch. Thanks.

>> +
>> +        log.info("Realm %s needs packages %s" % (self.discovered, ", ".join(self.packages)))
>> +
>> +    def execute(self, *args):
>> +        if not self.discovered:
>> +            return
>> +
>> +        pw_args = ["--no-password"]
>> +        for arg in self.join_args:
>> +            if arg.startswith("--no-password") or arg.startswith("--one-time-password"):
>> +                pw_args = []
> 'break' should go here?

Doesn't really matter, but is more readable, so added.

>>      def selectAnacondaNeeds(self):
>> -        for pkg in ['authconfig', 'chkconfig', 'system-config-firewall-base']:
>> +        for pkg in ['authconfig', 'chkconfig', 'realmd', 'system-config-firewall-base']:
> Do we really want 'realmd' installed on every system?

No. We do however need it in the installer. Once it's there, then the
anaconda realm command installs it (if necessary) on the system.

Should I remove it from the line above? What does the above reflect?
Because Anaconda does need it in this case. LMK.

Cheers,

Stef

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Set-the-local-hostname-during-the-install.patch
Type: text/x-patch
Size: 988 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121204/b05d496a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-support-for-the-realm-kickstart-command.patch
Type: text/x-patch
Size: 7469 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121204/b05d496a/attachment-0001.bin>


More information about the anaconda-patches mailing list