[PATCH] pykickstart realm support

Stef Walter stefw at redhat.com
Tue Dec 4 10:10:03 UTC 2012


On 11/30/2012 01:02 PM, Vratislav Podzimek wrote:
> 0001-Bump-for-Fedora-19-development.patch looks good to me.
> 
> Comments for 0002-Add-realm-command-to-join-domains-and-realms.patch
> follow as inline comments:

Thanks for the review. Fixed the various issues you pointed out in the
attached patch. A few comments below.

>> +            # We only support these args
>> +            opts, remaining = getopt.getopt(args, "v", ("client-software=", "server-software=", "membership-software=",
>> +                                                        "one-time-password=", "no-password=", "verbose", "computer-ou="))
> Have 'v' and 'verbose' any sense for use in kickstart/anaconda?

No I guess not. We should always force things to be verbose, the output
goes to the logs.

>> +    def __str__(self):
>> +        retval = KickstartCommand.__str__(self)
>> +
>> +        if self.join_args or self.after:
>> +            retval += "# Realm or domain membership\n"
>> +        if self.join_args:
>> +            args = [pipes.quote(arg) for arg in self.join_args]
>> +            retval += "realm join " + " ".join(self.join_args) + "\n"
>> +        for (command, args) in self.after:
>> +            args = [pipes.quote(arg) for arg in args]
>> +            retval += "realm " + command + " " + " ".join(args) + "\n"
>> +
>> +        return retval
> Could you please split the __str__ function to the code adding the comment and
> the "realm" string and adding and calling _getArgsAsStr method as we do in many
> other commands (e.g. timezone)? It's much better in case you want to add the
> F20_Realm class inheriting from F19_Realm later.

Done. Although this is slightly different because there are multiple
possible lines involved. However I believe the updated patch addresses
the case you mention above.

> Otherwise it looks good to me, but as I'm discussing with Stef and Martin Sivák, we could probably
> have this as a separate addon not part of pykickstart (and the same goes for the anaconda part).

In principle I'm fine with this, as long as it's possible to include the
addon along with Anaconda for many (most?) distributions in which
Anaconda is used.

What's the next step to get this going? How can I help?

Cheers,

Stef
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bump-for-Fedora-19-development.patch
Type: text/x-patch
Size: 7618 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121204/4be66e7c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-realm-command-to-join-domains-and-realms.patch
Type: text/x-patch
Size: 9229 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121204/4be66e7c/attachment-0003.bin>


More information about the anaconda-patches mailing list