[PATCH] Use BaseWindow.set_warning and set_error in GUIObject's methods

Vratislav Podzimek vpodzime at redhat.com
Tue Dec 4 08:54:59 UTC 2012


Commit 2c367ec88e7385892cb1cdd1f2e1a61079d2e5de brings set_info,
set_warning and set_error methods for our BaseWindow, but neither
Chris writing the patch nor me doing the review noticed that set_info
is used in all cases in the GUIObject's methods.

Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
---
 pyanaconda/ui/gui/__init__.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
index 52336f8..d0c2d5b 100644
--- a/pyanaconda/ui/gui/__init__.py
+++ b/pyanaconda/ui/gui/__init__.py
@@ -413,7 +413,7 @@ class GUIObject(common.UIObject):
            may not be able to do anything about, but that the user may.  A
            suitable background color and icon will be displayed.
         """
-        self.window.set_info(msg)
+        self.window.set_error(msg)
 
     def set_info(self, msg):
         """Display an info bar along the bottom of the screen with the provided
@@ -430,7 +430,7 @@ class GUIObject(common.UIObject):
            attend to in order to continue installation.  This is the bulk of
            messages.  A suitable background color and icon will be displayed.
         """
-        self.window.set_info(msg)
+        self.window.set_warning(msg)
 
 class QuitDialog(GUIObject):
     builderObjects = ["quitDialog"]
-- 
1.7.11.7



More information about the anaconda-patches mailing list