[PATCH 09/10] Only instantiate main line action objects when they are needed.

Chris Lumens clumens at redhat.com
Mon Dec 3 20:18:21 UTC 2012


> typo of taht carried forward.

The death of fun.

> > +        while not self._currentAction:
> > +            self._currentAction = self._instantiateAction(self._actions[0])
> > +            if not self._currentAction:
> > +                self._actions.pop(0)
> 
> I worry about this getting stuck. Nothing concrete, but maybe we should
> break or throw an error if _actions is empty?

I don't know that this is practically possible, but I suppose
theoretically it is.

I can just add to both places, like is happening in _on_continue_clicked
right now, something like this:

   if not self._actions:
      sys.exit(0)
      return

I don't know what else we could possibly do.

- Chris


More information about the anaconda-patches mailing list