[PATCH 09/10] Only instantiate main line action objects when they are needed.

Brian C. Lane bcl at redhat.com
Mon Dec 3 19:37:46 UTC 2012


On Fri, Nov 30, 2012 at 11:28:25AM -0500, Chris Lumens wrote:
> This prevents their strings from being translated before we know what language
> to translate them into, thus skipping the need for the whole retranslate
> thing.
> ---
>  pyanaconda/ui/gui/__init__.py | 105 +++++++++++++++++++++++++-----------------
>  1 file changed, 62 insertions(+), 43 deletions(-)

> +        # If we are doing a kickstart install, some standalone spokes
> +        # could already be filled out.  In taht case, we do not want

typo of taht carried forward.


> +        while not self._currentAction:
> +            self._currentAction = self._instantiateAction(self._actions[0])
> +            if not self._currentAction:
> +                self._actions.pop(0)

I worry about this getting stuck. Nothing concrete, but maybe we should
break or throw an error if _actions is empty?

> +        while not nextAction:
> +            nextAction = self._instantiateAction(self._actions[1])
> +            if not nextAction:
> +                self._actions.pop(1)

Similar worry here.

other than that, ACK to the whole set. Nice work!

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20121203/a0521754/attachment-0001.sig>


More information about the anaconda-patches mailing list