take II of networking patchset (write conf, init networking) for master

Chris Lumens clumens at redhat.com
Fri Aug 24 15:29:19 UTC 2012


> This is take II of
> https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-July/000283.html
> reviewed and commented by Chris. Compared to previous patchset:
> 
> [1/7] is the same as original [1/4]
> [2/7] ksdata argument of writeNetworkConf is added and ksdata is updated
>       with post-install changes of ifcfg files
> [3/7] is the same as original [2/4]
> [4/7] is the same as original [3/4]
> [5/7] is part of original [4/4] which consolidates code
> [6/7] is part of original [4/4] which adds ksdata.netwrok.hostname
>       - it has also related ks patch
>       - I updated required pykickstart version
> [7/7] reworked original [5/5]
>       - initializeNetwork is called in install.py instead of __init__
>         of StandaloneNetworkSpoke (see commit message)
>       - also fixes part of newui->master merge
> 
> [1/1] kickstart patch - adds new property also to RHEL7 compared to
>       original

Aside from my one or two little comments (which don't require you to
mail patches out again), this all looks fine.  Thanks.

- Chris


More information about the anaconda-patches mailing list