[PATCH] Deprecate the 'cmdline' command

Jesse Keating jkeating at redhat.com
Mon Aug 13 21:15:55 UTC 2012


On 08/13/2012 07:04 AM, Chris Lumens wrote:
>> For now make it set text mode instead of erroring.
>
> What's the plan for cmdline mode in the end?

There is only one text interface, and it's suitable for everything from 
serial to s390x to PC console.  In F19 / RHEL8 use of "cmdline" in 
kickstart would throw an error.  It'd be ignored on the command line as 
well.  "text" and "inst.text" are the true options.

>
>>   pykickstart/commands/displaymode.py | 33 +++++++++++++++++++++++++++++++++
>>   pykickstart/handlers/control.py     | 12 ++++++------
>>   2 files changed, 39 insertions(+), 6 deletions(-)
>
> You'll need to add a test case as well.

Good point.  I looked to make sure the change wouldn't break the tests, 
but didn't consider adding a new test to make sure it set things to text.


-- 
Jesse Keating
Fedora -- FreedomĀ² is a feature!


More information about the anaconda-patches mailing list