[PATCH 06/13] Add the new Summary hub and Password TUI spokes + tools to test TUI stuff

Martin Sivak msivak at redhat.com
Fri Aug 10 08:58:01 UTC 2012


Hi,

You category is too Gtk specific. It is a widget grouping the spokes together. I didn't want to create another abstract class hierarchy and then overriding all of those with GUI specific versions containing the widget code.

We do not have space for frames in TUI so category here is just a string identifier logically grouping the spokes together.
It serves the same purpose, strings are immutable and comparable so should be OK as an identifier.

Martin

----- Original Message -----
> > diff --git a/pyanaconda/ui/tui/hubs/summary.py
> > b/pyanaconda/ui/tui/hubs/summary.py
> > new file mode 100644
> > index 0000000..9411e4a
> > --- /dev/null
> > +++ b/pyanaconda/ui/tui/hubs/summary.py
> > @@ -0,0 +1,5 @@
> > +from pyanaconda.ui.tui.hubs import TUIHub
> > +
> > +class SummaryHub(TUIHub):
> > +    title = "Install hub"
> > +    categories = ["source", "localization", "destination",
> > "password"]
> 
> I must have missed something in a previous patch.  Can you explain
> the
> categories variable here?  It doesn't look anything like the
> categories
> in the GUI, which worries me a bit.  We need to keep things as
> similar
> as possible among all possible interfaces.
> 
> > diff --git a/pyanaconda/ui/tui/tools/run-spoke.py
> > b/pyanaconda/ui/tui/tools/run-spoke.py
> > new file mode 100755
> > index 0000000..d5e9c57
> > --- /dev/null
> > +++ b/pyanaconda/ui/tui/tools/run-spoke.py
> 
> Can this somehow be condensed into the GUI version so we only have
> one
> copy of all the common code?
> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list