[PATCH 0/5] replace lokkit for selinux

Vratislav Podzimek vpodzime at redhat.com
Thu Aug 9 08:15:17 UTC 2012


Apart from the two tests-related comments, these patches look good to
me.

On Wed, 2012-08-08 at 14:49 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
> 
> Well, it does a bit more than that :) I decided it was better to make
> SimpleConfigFile more generally useful, so I did that first. This also removes
> a whole file, so that's a bonus. I added tests to the simpleconfig tests to
> cover the new features as well.
> 
> I've tested this on pre-merge newui and it works. All the simpleconfig tests
> also pass.
> 
> Brian C. Lane (5):
>   simpleconfig: rewrite to better support commented config files
>   tests: cleanup whitespace in simpleconfig_test.py
>   tests: Add tests for new SimpleConfigFile features
>   replace lokkit for selinux settings (#815540)
>   remove Security class
> 
>  pyanaconda/__init__.py                     |    4 +-
>  pyanaconda/install.py                      |    1 +
>  pyanaconda/kickstart.py                    |   20 +++
>  pyanaconda/security.py                     |   63 --------
>  pyanaconda/simpleconfig.py                 |  222 ++++++++++++++++++----------
>  tests/pyanaconda_test/simpleconfig_test.py |   90 ++++++++----
>  6 files changed, 227 insertions(+), 173 deletions(-)
>  delete mode 100644 pyanaconda/security.py
> 

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list