[PATCH] ARM: add command line option to set the platform.

David A. Marlin dmarlin at redhat.com
Thu Aug 2 20:50:15 UTC 2012


Jon Masters wrote:
> On 08/02/2012 04:38 PM, Brian C. Lane wrote:
>   
>> On Wed, Aug 01, 2012 at 04:15:14AM -0500, Dennis Gilmore wrote:
>>     
>>> El Mon, 23 Jul 2012 13:35:24 -0700
>>> "Brian C. Lane" <bcl at redhat.com> escribió:
>>>       
>>>> On Mon, Jul 16, 2012 at 09:04:10AM -0500, Dennis Gilmore wrote:
>>>>         
>>>>> Use case is to create images using livemedia-creator where we wont
>>>>> be running on the target platform
>>>>>
>>>>> Signed-off-by: Dennis Gilmore <dennis at ausil.us>
>>>>> ---
>>>>>  anaconda            |    4 ++++
>>>>>  pyanaconda/iutil.py |    3 +++
>>>>>  2 files changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/anaconda b/anaconda
>>>>> index fc679c9..c37dd72 100755
>>>>> --- a/anaconda
>>>>> +++ b/anaconda
>>>>> @@ -222,6 +222,7 @@ def parseOptions(argv=None, cmdline=None):
>>>>>      op.add_option("--kickstart", dest="ksfile")
>>>>>      op.add_option("--rescue", dest="rescue", action="store_true",
>>>>> default=False) op.add_option("--targetarch", "rpmarch",
>>>>> dest="targetArch", type="string")
>>>>> +    op.add_option("--targetplatform", "platform",
>>>>> dest="targetPlatform", type="string")
>>>>>           
>>>> Ideally this would be generic enough that it would apply to any arch.
>>>> But that's going to be fairly difficult given how tightly Anaconda is
>>>> integrated with the system it is running on. So for now I guess this
>>>> is ok, but I'd like so see the option renamed to --armplatform since
>>>> it is specific to arm.
>>>>
>>>>         
>>> right the way its implemented it could be used to overwrite things like
>>> making a uefi only livecd on a non uefi system or for different ppc
>>> system types.  I do only see it being used initially for ARM but its
>>> not implemented so that its the only way to use it. id rather not
>>> rename it but if you insist that is how its done ill do it.
>>>       
>> That was my point. We have a variety of ways we interact with the
>> platform so for now it is better to make it clear this is just for ARM.
>>     
>
> Ok. I'm keen that we get at least the first 2.5 (2+the trivial kernel
> style fix from Dennis) ARM patches in that do the platform stuff for
> F18. I'd like to see the U-Boot stuff land as well, but the arm platform
> stuff is critical. Therefore, Brian, can you confirm that if Dennis
> changes that platform name to whatever you prefer and rebases tonight
> (his tomorrow - he's in AU right now) you can ACK/pull tomorrow?
>   
If we change the command line option, we also need to ensure the lorax 
patch is changed as well to match it.

  
https://www.redhat.com/archives/anaconda-devel-list/2012-July/msg00060.html

I will be happy to rebase this one, if needed.  Please let me know.


Thank you,

d.marlin
========

> Jon.
>
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>   



More information about the anaconda-patches mailing list