<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 09/27/2012 10:40 AM, mtaylor wrote:<br>
</div>
<blockquote
cite="mid:aeolus-incubator%2Fimage-management-engine%2Fpull%2F20%2Fr1704794@github.com"
type="cite">
<p>In app/models/image_management/provider_image.rb:</p>
<pre style="color:#555">>
> - accepts_nested_attributes_for :target_image
> + # FIXME Check to see if this is a setting we can add to Rails configuration.
> + # i.e. json_include_resource_name = true
</pre>
<p>Thanks. I'll remove those methods and update the config.</p>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">
—<br>
Reply to this email directly or <a moz-do-not-send="true"
href="https://github.com/aeolus-incubator/image-management-engine/pull/20/files#r1704794">view
it on GitHub</a>. </p>
<img moz-do-not-send="true"
src="https://github.com/notifications/beacon/J6T91GIPIyhU-8ti4GCGP12AWctNuG_ZejXUp5y2I1cXestgxk-xlNE77j5uxE5V.gif"
height="1" width="1">
</blockquote>
It seems that github does not send a mail when a comment is
updated. In case you are following comments in mail I've pasted my
updated comment below:<br>
<br>
<div class="edit-comment-hide">
<div class="js-comment-body comment-body markdown-body
markdown-format">
<p>Thanks. I'll remove those methods and update the config.</p>
<h3>Comment 2</h3>
<p>After a little more consideration, I'm not sure we want to
set this in the config. The setting is on ActiveRecord::Base
and therefore would override any settings in the host
application. I am going to leave this as it is for now and
follow this up later with a patch. We could implement this
using this setting but by either:</p>
<ul>
<li>
<p>Setting this in the controller using: e.g.
user.as_json(root: false)</p>
</li>
<li>
<p>Adding another class in the chain that will be used for
any ActiveRecord settings specific to ImageManagement. For
example:</p>
</li>
</ul>
<p>class ImageManagement::Base < ActiveRecord::Base<br>
include_root_in_json = false<br>
end</p>
<p>class ImageManagement::TargetImage < ImageManagement::Base<br>
...</p>
<p>What are your thoughts?</p>
</div>
</div>
<br>
<br>
</body>
</html>