[PATCH conductor] BZ 809787 - Fixes untranslated table header

Tzu-Mainn Chen tzumainn at redhat.com
Wed Sep 19 20:33:11 UTC 2012


ACK/pushed.

----- Original Message -----
> From: "Matt Wagner" <matt.wagner at redhat.com>
> To: aeolus-devel at lists.fedorahosted.org
> Sent: Wednesday, September 19, 2012 3:58:49 PM
> Subject: [PATCH conductor] BZ 809787 - Fixes untranslated table header
> 
> For some reason this table header was never updated to use
> strings from en.yml, or even uppercase strings.
> 
> Because it's after string freeze, I had to be slightly creative
> in fitting things in, so I left a comment suggesting that the
> keys I used might need cleanup later.
> 
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=809787
> but is equally as useful upstream.
> ---
>  src/app/controllers/pools_controller.rb |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/app/controllers/pools_controller.rb
> b/src/app/controllers/pools_controller.rb
> index de4d60f..7ae9189 100644
> --- a/src/app/controllers/pools_controller.rb
> +++ b/src/app/controllers/pools_controller.rb
> @@ -128,8 +128,10 @@ class PoolsController < ApplicationController
>          when 'images'
>            # this case covers fetching of unique images and
>            constructing
>            # collection for filter table
> -          @header = [{:name => "catalog"}, {:name => "deployable"},
> -                     {:name => "image"}, {:name =>
> "provider_image"}]
> +          # 19sept2012 -- FIXME - These aren't really the correct
> translation names, but
> +          #  this patch is after string freeze so I'm confined to
> using them. --mawagner
> +          @header = [{:name => t("pools.images.catalog")}, {:name =>
> t("catalog_entries.index.catalog_entry")},
> +                     {:name => t("logs.index.image")}, {:name =>
> t("images.show.providers_image_id")}]
>            @catalog_images = @pool.catalog_images_collection(
>              @pool.catalogs.list_for_user(current_session,
>              current_user,
>                                           Privilege::VIEW))
> --
> 1.7.7.6
> 
> 



More information about the aeolus-devel mailing list