[PATCH 0/3 conductor] RM3393 - Add graphs to the audit history page

Tzu-Mainn Chen tzumainn at redhat.com
Tue Jun 19 15:42:57 UTC 2012


Thanks for the feedback!  I've made the suggested edits and pushed the patchset.

Mainn

----- Original Message -----
> From: "Jirka Tomasek" <jtomasek at redhat.com>
> To: aeolus-devel at lists.fedorahosted.org
> Sent: Tuesday, June 19, 2012 7:15:59 AM
> Subject: Re: [PATCH 0/3 conductor] RM3393 - Add graphs to the audit history	page
> 
> 
> On 06/18/2012 06:17 PM, Tzu-Mainn Chen wrote:
> 
> 
> This page links to the flot library from the converge-ui, and uses it
> to generate graphs based on the audit history (which is now linked
> from the main Monitor page).  Graphs can be adjusted for date range,
> and also "group by" options (group by pool, provider, user, etc).
> 
> Mainn
> ACK.
> 
> Nits: - please add en.breadcrumbs.logs translation (getting error in
> breadcrumbs)
> - please add logs to config/navigation.rb to enable Monitor tab
> highlight when on the Logs page: ( line21: first_level . item
> :monitor , t ( 'navigation.first_level.monitor' ), pools_path ,
> :class => 'monitor' , :link => { :id => 'monitor' }, :highlights_on
> => /\/deployments|\/pools |\/instances |\/logs |\/\z/ )
> 
> Also the third patch contains trailing whitespaces and some really
> long lines.
> 
> Btw. nice graphs!
> 
> Jirka
> 
> 



More information about the aeolus-devel mailing list