[PATCH aeolus-cli] BZ804543 Removed Optional Element for rootpw in tdl
Jan Provaznik
jprovazn at redhat.com
Fri Jun 1 08:06:22 UTC 2012
On 05/23/2012 08:14 PM, mtaylor at redhat.com wrote:
> From: Martyn Taylor<mtaylor at redhat.com>
>
> ---
> examples/tdl.rng | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/examples/tdl.rng b/examples/tdl.rng
> index e302a3a..b7eae58 100644
> --- a/examples/tdl.rng
> +++ b/examples/tdl.rng
> @@ -79,11 +79,9 @@
> <ref name='iso'/>
> </choice>
> </element>
> -<optional>
> -<element name='rootpw'>
> -<text/>
> -</element>
> -</optional>
> +<element name='rootpw'>
> +<text/>
> +</element>
> <optional>
> <element name='key'>
> <text/>
Hi Martyn,
what is the reason to have the XML schema validation in aeolus-cli.
Aeolus-cli is just very thin layer which gets params from a user and
sends them to Conductor.
I think that the XML validation should be done only by Imagefactory
since it's only component which processes the template. True is that
this validation is now done also on Conductor side but only reason for
this is that Imagefactory doesn't have API call for template validation.
I see that in app/controllers/api/images_controller.rb is some logic
which returns validation errors if the template is invalid so I would
say that the validation on aeolus-cli side can be removed.
Jan
More information about the aeolus-devel
mailing list