[PATCH 3/4] redmine #3452: verify value of template to render in realms and provider_realms controller

Mo Morsi mmorsi at redhat.com
Tue Jul 31 20:06:27 UTC 2012


The only other thing that I had noticed w/ the realms / provider_realms
controllers is that we don't restrict access to viewing / listing the
realms in any way (eg they are globally accessible). Just wanted to make
sure that this is correct.

  -Mo

On 07/31/2012 04:03 PM, Mo Morsi wrote:
> ---
>  src/app/controllers/provider_realms_controller.rb |    1 +
>  src/app/controllers/realms_controller.rb          |    1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/src/app/controllers/provider_realms_controller.rb b/src/app/controllers/provider_realms_controller.rb
> index f4ad966..9c9d48c 100644
> --- a/src/app/controllers/provider_realms_controller.rb
> +++ b/src/app/controllers/provider_realms_controller.rb
> @@ -34,6 +34,7 @@ class ProviderRealmsController < ApplicationController
>  
>      @tab_captions = [t('realms.tab_captions.properties'), t('realms.tab_captions.mapping')]
>      @details_tab = params[:details_tab].blank? ? 'properties' : params[:details_tab]
> +    @details_tab = 'properties' unless ['properties', 'mapping'].include?(@details_tab)
>  
>      @frontend_realms_for_provider = @realm.provider.frontend_realms
>      @frontend_realms = @realm.frontend_realms
> diff --git a/src/app/controllers/realms_controller.rb b/src/app/controllers/realms_controller.rb
> index 695f1e2..f908e43 100644
> --- a/src/app/controllers/realms_controller.rb
> +++ b/src/app/controllers/realms_controller.rb
> @@ -113,6 +113,7 @@ class RealmsController < ApplicationController
>      @title = @realm.name
>      @tab_captions = [t('realms.tab_captions.properties'), t('realms.tab_captions.mapping')]
>      @details_tab = params[:details_tab].blank? ? 'properties' : params[:details_tab]
> +    @details_tab = 'properties' unless ['properties', 'mapping'].include?(@details_tab)
>  
>      @backend_realm_targets = @realm.realm_backend_targets.select { |x| x.realm_or_provider_type == 'Realm' }
>      @backend_provider_targets = @realm.realm_backend_targets.select { |x| x.realm_or_provider_type == 'Provider' }




More information about the aeolus-devel mailing list