[PATCH] fix for delayed_job launches to pass ids instead of objects

Imre Farkas ifarkas at redhat.com
Fri Jul 20 09:18:19 UTC 2012


On 07/19/2012 07:39 AM, Justin Clift wrote:
> On 18/07/2012, at 11:13 PM, Tzu-Mainn Chen wrote:
>> ---
>> src/app/models/deployment.rb |   33 +++++++++++++++++++++------------
>> 1 files changed, 21 insertions(+), 12 deletions(-)
>>
>> diff --git a/src/app/models/deployment.rb b/src/app/models/deployment.rb
>> index be60802..277f9b3 100644
>> --- a/src/app/models/deployment.rb
>> +++ b/src/app/models/deployment.rb
>> @@ -254,23 +254,32 @@ class Deployment < ActiveRecord::Base
>>      all_inst_match.map!{|m| m.attributes}
>
>
>  From a functional perspective, this works. (whoo hooo!) :)
>
> However, something with Ruby skills should probably code
> review this just to be sure. :>
>
> Regards and best wishes,
>
> Justin Clift
>
> --
> Aeolus Community Manager
> http://www.aeolusproject.org
>

Code review done, ACK! :-)



More information about the aeolus-devel mailing list