[PATCH conductor] BZ 833767 Fixed css in deployment#launch_time_params view
Jirka Tomasek
jtomasek at redhat.com
Thu Jul 19 13:35:10 UTC 2012
On 07/18/2012 05:11 PM, jzigmund at redhat.com wrote:
> From: Jozef Zigmund <jzigmund at redhat.com>
>
> ---
> src/app/views/deployments/launch_time_params.html.haml | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/src/app/views/deployments/launch_time_params.html.haml b/src/app/views/deployments/launch_time_params.html.haml
> index d50781e..f5e080b 100644
> --- a/src/app/views/deployments/launch_time_params.html.haml
> +++ b/src/app/views/deployments/launch_time_params.html.haml
> @@ -14,7 +14,8 @@
> %section.services
> .labels
> - @services.each do |service, assembly_name|
> - %h4.service{:id => service.id}= service.name.titleize
> + - binding.pry
This line should not be here
> + %h4.service{:id => service.name}= service.name.titleize
> %p.hidden.description= service.description
>
> %header
> @@ -23,9 +24,9 @@
>
> .params-container
> - @services.each do |service, assembly_name|
> - .parameters{:id => service.id}
> + .parameters{:id => service.name}
> - service.parameters.each do |parameter|
> - .parameter
> + .parameter.field
> - if not parameter.reference?
> - id = "deployment[launch_parameters][#{assembly_name}][#{service.name}][#{parameter.name}]"
> = label_tag id, parameter.name.titleize + ':'
> @@ -33,9 +34,11 @@
> - if parameter.type == "password"
> = password_field_tag id, (parameter.value or value)
> - elsif (parameter.value or value).to_s.include?("\n")
> - = text_area_tag id, (parameter.value or value), :class => 'long'
> + .input
> + = text_area_tag id, (parameter.value or value), :class => 'long'
> - else
> - = text_field_tag id, (parameter.value or value)
> + .input
> + = text_field_tag id, (parameter.value or value)
> - else
> = t('.reference', :assembly => parameter.reference_assembly, :parameter => parameter.reference_parameter)
>
Hi,
Conditional ACK, one note inline and please add following changes to
this patch:
1) please add class "generic horizontal" to the services form
2) with the first change you can remove lines 120-130 from _custom.scss
not related to patch but please fix this too
3) change the padding for labels defined in layout.scss
line 2250 to padding: 4px 0px 3px 0px;
line 2253 to padding: 2px 7px 0px 0px;
line 2256 to padding: 8px 7px 7px 0px;
Thanks
Jirka
More information about the aeolus-devel
mailing list