[PATCH conductor 0/3] Provider Account API - show action

Richard Su rwsu at redhat.com
Thu Jul 19 01:07:44 UTC 2012


On 07/18/2012 09:31 AM, Petr Blaho wrote:
> On Thursday, July 12, 2012 05:30:31 PM Richard Su wrote:
>> On 07/12/2012 07:40 AM, pblaho at redhat.com wrote:
>>> https://www.aeolusproject.org/redmine/issues/3424
>>>
>> Looks good overall. I think we do need to test attributes specific to
>> different provider types, notably ec2. You indicated this too as a TODO.
>> But I think we should implement it now. This is something that is easy
>> to forget and could bite us in the future.
>>
>> Conditional ack.
>>
> Do you think it is a good idea to write tests for every provider type we have?
> Like set of tests for mock(?), ec2, rhev-m, ... ?

I think ec2 would be good enough for now. The other providers have 
similar fields.
>
> I have modified tests of provider accounts to "load" what fields XML response should have from Factory for that provider account.
> Like "display every field for credentials". Is this good enough? Using Factories like definitions?
>
That would work. Does it also check values?




More information about the aeolus-devel mailing list