[PATCH aeolus-cli] aeolus-cli extended with hwp functionality

Mo Morsi mmorsi at redhat.com
Mon Jul 2 15:03:08 UTC 2012


On 07/02/2012 10:38 AM, Jason Guiditta wrote:
> On 29/06/12 14:06 +0530, Samridh wrote:
>> This patch adds hwp creation, deletion and listing functionality to
>> the cli.
>>
>> To test the functionality, please modify the :url entry in your
>> ~/.aeolus-cli file to something like ":url: http://<host>/conductor"
>> i.e, remove the /api from the :url entry. This is because all the
>> conductor side funcitonality has been implemented by modifying the
>> hardware_profile cotroller itself. You could also modify the
>> routes.rb on the conductor side, but I personally found the former
>> easier to do.
>

Jay, appreciate the feedback


> I'll try to reply in more detail later, but this is not going to be
> able to go in as is.  I'll list a few of the large problems here, and
> get into details later or tomorrow once I finish some other things on
> my todo list:
> * You can't break the entrypoint in the configu file like this, it
>   will cause the existing stuff that _does_ require /api in the uri to
>   break

We had previously discussed that the /api controller namespace would be
merged into the top level controller layer for conductor, leveraging the
same methods the web interface uses, but simply returning responses in
XML format.

Since all new additions will not leverage the /api namespace, I feel it
would make more sense to continue forward in this direction, and not
incorporate '/api' into the cli entry point. The controllers currently
in the api namespace will need to be integrated into the top level
controller layer in conductor in whatever case.




> * hwp is _not_ a bolton to aeolus-image, it belongs in a separate
>   command (this could be just hwp or something else, not sure
>   offhand).  Calling aeolus-image --hwp makes no sense, as an hwp is
>   not an image.

Weren't we going to rename the 'aeolus-image' command to be 'aeolus-cli'
so that it is more applicable to general purpose conductor management. I
thought this was the point of incorporating the subcommands into the cli
utilities, with the end goal being to be able to manage all the
conductor entities from the command line.




> * where are the tests?  we cannot accept new functionality without
>   tests.

Agree on this one, the new additions could use some specs and similar to
verify functionality. Should be straightforward to add as there are
plenty of examples in place of how to do things.

  -Mo




More information about the aeolus-devel mailing list